Skip to content

WorkingSetActionProvider: fix "Widget is disposed" #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

WorkingSetActionProvider: fix "Widget is disposed" #2375

merged 2 commits into from
Oct 9, 2024

Conversation

@jukzi
Copy link
Contributor

@jukzi jukzi commented Oct 9, 2024

as logged during LabelProviderTest

asyncExec can happen when viewer is already disposed

@jukzi
WorkingSetActionProvider: fix "Widget is disposed"
9982450 
as logged during LabelProviderTest

asyncExec can happen when viewer is already disposed
@jukzi
Copy link
Contributor Author

jukzi commented Oct 9, 2024

for example
https://download.eclipse.org/eclipse/downloads/drops4/I20241007-1800/testresults/ep434I-unit-win32-java17_win32.win32.x86_64_17/org.eclipse.ui.tests.navigator.NavigatorTestSuite.txt

org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4922)
	at org.eclipse.swt.SWT.error(SWT.java:4837)
	at org.eclipse.swt.SWT.error(SWT.java:4808)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:500)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:419)
	at org.eclipse.swt.widgets.Tree.getSelection(Tree.java:3550)
	at org.eclipse.jface.viewers.TreeViewer.getSelection(TreeViewer.java:233)
	at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:310)
	at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:2785)
	at org.eclipse.ui.navigator.CommonViewer.setSelectionToWidget(CommonViewer.java:439)
	at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:3251)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1399)
	at org.eclipse.jface.viewers.TreeViewer.preservingSelection(TreeViewer.java:367)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1353)
	at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1486)
	at org.eclipse.jface.viewers.ColumnViewer.refresh(ColumnViewer.java:533)
	at org.eclipse.ui.navigator.CommonViewer.refresh(CommonViewer.java:352)
	at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1447)
	at org.eclipse.jface.viewers.StructuredViewer.setFilters(StructuredViewer.java:1579)
	at org.eclipse.ui.internal.navigator.NavigatorFilterService.updateViewer(NavigatorFilterService.java:287)
	at org.eclipse.ui.internal.navigator.resources.actions.WorkingSetActionProvider.setWorkingSetFilter(WorkingSetActionProvider.java:273)
	at org.eclipse.ui.internal.navigator.resources.actions.WorkingSetActionProvider.setWorkingSetFilter(WorkingSetActionProvider.java:256)
	at org.eclipse.ui.internal.navigator.resources.actions.WorkingSetActionProvider.setWorkingSet(WorkingSetActionProvider.java:308)
	at org.eclipse.ui.internal.navigator.resources.actions.WorkingSetActionProvider.initWorkingSetFilter(WorkingSetActionProvider.java:251)
	at org.eclipse.ui.internal.navigator.resources.actions.WorkingSetActionProvider.lambda$2(WorkingSetActionProvider.java:342)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4162)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3778)
	at org.eclipse.ui.tests.harness.util.DisplayHelper.driveEventQueue(DisplayHelper.java:181)
	at org.eclipse.ui.tests.harness.util.DisplayHelper.waitForCondition(DisplayHelper.java:67)
	at org.eclipse.ui.tests.harness.util.DisplayHelper.sleep(DisplayHelper.java:124)
	at org.eclipse.ui.tests.harness.util.DisplayHelper.sleep(DisplayHelper.java:103)
	at org.eclipse.ui.tests.navigator.LabelProviderTest.testOverrideChain(LabelProviderTest.java:245)

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Oct 9, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From f594b8f952d0a51e89e1dfadd3892f32b0747e2a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 9 Oct 2024 13:00:31 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 4f37678762..5e9f968e31 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.400.qualifier
+Bundle-Version: 3.9.500.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 44m 25s ⏱️ + 10m 32s
 7 704 tests ±0   7 476 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 273 runs  ±0  23 526 ✅ ±0  747 💤 ±0  0 ❌ ±0 

Results for commit 722c158. ± Comparison against base commit 7d29a59.

@jukzi jukzi merged commit b85d17e into eclipse-platform:master Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jukzi @eclipse-platform-bot